Skip to content

Conversation

@kko27
Copy link
Contributor

@kko27 kko27 commented Feb 9, 2026

Resolves #407

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 82.77512% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.77%. Comparing base (869da67) to head (218b312).

Files with missing lines Patch % Lines
Code/Source/solver/Parameters.cpp 70.00% 27 Missing ⚠️
Code/Source/solver/cep_ion.cpp 65.00% 7 Missing ⚠️
Code/Source/solver/CepModTtp.cpp 94.44% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
+ Coverage   67.70%   67.77%   +0.07%     
==========================================
  Files         168      168              
  Lines       32752    32873     +121     
  Branches     5750     5792      +42     
==========================================
+ Hits        22176    22281     +105     
- Misses      10439    10455      +16     
  Partials      137      137              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ktbolt
Copy link
Collaborator

ktbolt commented Feb 9, 2026

@kko27 This PR is eight months old, that will not do !

@kko27
Copy link
Contributor Author

kko27 commented Feb 9, 2026

@kko27 This PR is eight months old, that will not do !

@ktbolt, sorry about that. What should I do in this situation? Should I create a new branch in my fork and then include these changes

@ktbolt
Copy link
Collaborator

ktbolt commented Feb 9, 2026

@kko27 It is best to get PRs merged as soon as possible, makes them easier to review.

I think creating a new branch in your fork and then including the changes there will be ok, I don't think you changed too many files.

I think that you can also create a commit from a diff of two branches but I've never done that.

@kko27
Copy link
Contributor Author

kko27 commented Feb 10, 2026

@kko27 It is best to get PRs merged as soon as possible, makes them easier to review.

I think creating a new branch in your fork and then including the changes there will be ok, I don't think you changed too many files.

I think that you can also create a commit from a diff of two branches but I've never done that.

Thanks! Will close this PR and will create new branch

@kko27 kko27 closed this Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hard coded initial conditions for EP simulations (TTP ionic model)

2 participants