Default cookie setter in OAuth is not setting samesite = None #352#353
Open
Kudze wants to merge 1 commit intoShopify:mainfrom
Open
Default cookie setter in OAuth is not setting samesite = None #352#353Kudze wants to merge 1 commit intoShopify:mainfrom
Kudze wants to merge 1 commit intoShopify:mainfrom
Conversation
Author
|
I have signed the CLA! |
Contributor
|
Wouldn't this make cookies 3rd party cookies? If so I'm not sure we want them as browser will start block them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #352
For context read the issue I created.
WHAT is this pull request doing?
Basically sets samesite=none for cookies created in OAuth2.
Type of change
Checklist