Add deletion and raw http endpoint urls for Webhooks#304
Open
sfinktah wants to merge 5 commits intoShopify:mainfrom
Open
Add deletion and raw http endpoint urls for Webhooks#304sfinktah wants to merge 5 commits intoShopify:mainfrom
sfinktah wants to merge 5 commits intoShopify:mainfrom
Conversation
I also have this problem. Why does it do that?! |
Author
Because it's retarded. Making a clever fix like you suggest is how I would normally solve the problem myself, however with production code it is best not to change the behavior of existing functions. |
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
I couldn't add a webhook, because it insists on making all HttpDelivery webhooks a path of Context::$HOST_NAME (which was myshop.myshopify.com), and I wanted a webhook on my server.
I also couldn't delete a webhook.
WHAT is this pull request doing?
Added a new enum to Webhooks::Registry::register
which doesn't try and get smart with the provided url
To allow deletion of webhooks with the maximum code re-use, I modified Webhooks::Registry::register to equate an empty
$pathwith a request to delete the webhook.Type of change
Checklist
There's documentation?