Fix array filters to not support nested properties#1907
Merged
ggmichaelgo merged 1 commit intomainfrom Jan 31, 2025
Merged
Conversation
This was referenced Jan 31, 2025
ggmichaelgo
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes support for nested properties.
We have conducted additional assessments regarding the backward compatibility aspect of this change and discovered it is not 100% backward compatible with all runtimes and temples. We are keeping the new filters, but nested properties will be re-assessed and implemented by #1906.
We have valuable concerns raised by the community, along with powerful alternatives that warrant deeper consideration.
Nested properties must still be supported, but they will not be part of 5.7.x, as the required work is more significant than initially stated.