Fix the find filter to return nil when filtering empty arrays#1902
Merged
Fix the find filter to return nil when filtering empty arrays#1902
find filter to return nil when filtering empty arrays#1902Conversation
c6578d8 to
2883fd5
Compare
frandiox
approved these changes
Jan 23, 2025
frandiox
left a comment
There was a problem hiding this comment.
Code looks good 👍 -- What about find_index, though?
Contributor
Author
|
Thanks a lot for the review, @frandiox! I've applied the fixes for |
graygilmore
approved these changes
Jan 23, 2025
EvilGenius13
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a patch that addresses an issue in the
findfilter introduced by #1869.When filtering an empty array, the
findfilter should returnnil, just as it returns the found element when it locates the desired element ornilwhen the element cannot be found. However, it was incorrectly returning an empty array.