Remove blank nodes from AST with omit_blank_nodes option#1870
Draft
ggmichaelgo wants to merge 3 commits intomainfrom
Draft
Remove blank nodes from AST with omit_blank_nodes option#1870ggmichaelgo wants to merge 3 commits intomainfrom
ggmichaelgo wants to merge 3 commits intomainfrom
Conversation
e862c27 to
6e3e26b
Compare
Contributor
|
I think this means comments won't be available in the AST anymore right? That might break tools using AST walking to inspect comments. I only know of https://github.com/Shopify/theme-check, but it's deprecated. So might be good. Do you think that might be an issue? |
Contributor
Author
oh good point... it should be configurable to omit these nodes 👍 |
c680e11 to
628f4aa
Compare
628f4aa to
9a4350b
Compare
|
Hello from an AST-walking codebase! 👋 Thanks for thinking of us! 🥰 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using
omit_blank_nodesparse option, Parser will omitCommentnode and other empty nodes from the AST.For example,
Iftag like this won't be included in the AST: