Closed
Conversation
Co-Authored-By: ADTC <ADTC@users.noreply.github.com>
Co-authored-by: Dylan Thacker-Smith <dylan.smith@shopify.com>
This comment was marked as resolved.
This comment was marked as resolved.
|
I’m not a ruby developer but it seems you also added a nice feature on the reject filter allowing to filter nested objects. This should most likely be backported to the where filter as well. |
Contributor
Author
That has proven a bit harder, as there is some backward compatibility we need to take care of: #1436 |
karreiro
pushed a commit
that referenced
this pull request
Dec 3, 2024
karreiro
added a commit
that referenced
this pull request
Jan 14, 2025
* Add reject filter #1573 * Add deep search for filter taking in properties #1749 * Update branch with main * Add `find`, `find_index`, `has`, and `reject` filters to arrays * Refactor: avoid usage of public_send --------- Co-authored-by: Anders Søgaard <andershagbard@gmail.com> Co-authored-by: Anders Søgaard <9662430+andershagbard@users.noreply.github.com>
Contributor
Author
|
Solved in #1869 |
andrykonchin
pushed a commit
to andrykonchin/liquid
that referenced
this pull request
Feb 24, 2025
…ify#1869) * Add reject filter Shopify#1573 * Add deep search for filter taking in properties Shopify#1749 * Update branch with main * Add `find`, `find_index`, `has`, and `reject` filters to arrays * Refactor: avoid usage of public_send --------- Co-authored-by: Anders Søgaard <andershagbard@gmail.com> Co-authored-by: Anders Søgaard <9662430+andershagbard@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This filter adds the inverse of the
wherefilter.This filter also allows deep searching with dot notation.
Idea from: #1555