Open
Conversation
kpy815
approved these changes
Nov 6, 2020
hc0503
approved these changes
Nov 9, 2020
Contributor
|
Based on Shopify/liquid-c#123, it looks like we actually have themes that depend on this liquid quirk. We might want to consider just supporting that syntax. It isn't actually that unreasonable. For example, it is valid syntax in python It is also considered acceptable syntax in math, even though the |
|
Boa tarde, já não tenho a loja online, por favor podem anular a minha
subscrição.
Obrigado.
Maria Lopes
Dylan Thacker-Smith ***@***.***> escreveu no dia segunda,
31/10/2022 à(s) 13:25:
… Based on Shopify/liquid-c#123
<Shopify/liquid-c#123>, it looks like we actually
have themes that depend on this liquid quirk.
We might want to consider just supporting that syntax. It isn't actually
that unreasonable. For example, it is valid syntax in python
$ python
Python 3.10.3 (main, Jul 4 2022, 12:12:23) [Clang 13.1.6 (clang-1316.0.21.2.5)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> -.1
-0.1
It is also considered acceptable syntax in math, even though the 0
preceding the decimal point is typically preferred for readability.
—
Reply to this email directly, view it on GitHub
<#1343 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZRI4DOKUAWWXMWA7Z2XH6TWF7CDHANCNFSM4TLOFQCQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for Shopify/liquid-c#120.