Create update before insert trigger#181
Merged
coding-chimp merged 2 commits intomasterfrom Jul 8, 2025
Merged
Conversation
riccardo-casazza
approved these changes
Jul 8, 2025
grodowski
approved these changes
Jul 8, 2025
455255a to
e0a3a14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the order we create triggers in to prevent the following scenario:
Result: The inserts were replicated to the shadow table via the insert trigger, but the updates were not. Copying those rows failed since they already existed in the shadow table, and LHM ignored the error. We now have stale data after the migration finishes.
We ensure this can't happen by creating the update trigger first.