Upgrade to jcifs-ng 2.1.7 and latest slf4j featured wrapper#1
Open
PhilZ-cwm6 wants to merge 3 commits intoSentaroh:1.0.9from
Open
Upgrade to jcifs-ng 2.1.7 and latest slf4j featured wrapper#1PhilZ-cwm6 wants to merge 3 commits intoSentaroh:1.0.9from
PhilZ-cwm6 wants to merge 3 commits intoSentaroh:1.0.9from
Conversation
- upgrades to jcifs-ng can be done without editing sources, just recompile against slf4j wrapper - new slf4j wrapper supports new logger formatting options used in jcifsng and any future lib relying on slf4j
d0cbb11 to
3430713
Compare
3430713 to
9b00282
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lib sources:
jcifs-ng 2.1.7 repo, just recompiling jcifs-ng with new slf4j wrapper:
https://github.com/PhilZ-cwm6/jcifs-ng
jcifs 1.3.17, modified class:
https://github.com/PhilZ-cwm6/jcifs-1.3.17
jcifs 1.3.19, modified class:
https://github.com/PhilZ-cwm6/jcifs-1.3.19