This repository was archived by the owner on Oct 1, 2025. It is now read-only.
Pythonize run_unit_tests.sh#58
Open
XuefengHuang wants to merge 2 commits intoSeattleTestbed:masterfrom
XuefengHuang:add-run_unit_tests.py
Open
Pythonize run_unit_tests.sh#58XuefengHuang wants to merge 2 commits intoSeattleTestbed:masterfrom XuefengHuang:add-run_unit_tests.py
XuefengHuang wants to merge 2 commits intoSeattleTestbed:masterfrom
XuefengHuang:add-run_unit_tests.py
Conversation
This helper script for Seattle Testbed, https://seattle.poly.edu/, * downloads Seattle Testbed's sources from GitHub, * builds them using Seattle's build scripts, and finally * runs Seattle's unit tests.
Author
|
This is part of the PR's test result: |
Contributor
|
Okay, thanks for your initiative on this. Here's a few things I noticed:
Did you have a chance to run this on Windows btw? Do we have a tester with access to a Win box? |
| # For every repo name, ... | ||
| for repo in repolist: | ||
| print "Testing " + testbed + '/' + repo + " now..." | ||
| print "https://github.com/" + testbed + "/" + repo + ".git" |
There was a problem hiding this comment.
Should we make the domain name configurable, too? For example, if a local or non-github git repository is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helper script for Seattle Testbed, https://seattle.poly.edu/,