chore: prefer ArrayPartitionStyle to preserve nesting structure#483
chore: prefer ArrayPartitionStyle to preserve nesting structure#483DhairyaLGandhi wants to merge 5 commits intoSciML:masterfrom
Conversation
|
Rebase for the tests? |
|
I have a question, what purpose does nesting ARrayPartitions serve and is that a structure that should be maintained? Because we could always flatten the paritions of the children as partitions of the parent directly right? |
|
For the context in #480 originally comes from, no please do not flatten the structure: In that setting we handle elements on a product manifold with ArrayPartitions. We do not have to dive into manifolds, set products are enough: Imagine you are on a set If you internally handle that in a fancy-flattened way, sure, feel free ;) But on the outer I would like to access the first or second element of |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Ref #480
Add any other context about the problem here.