You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updated only the kubernetes reference files ... adoc/docinfo.xml and adoc/SA_vars.adoc and adoc/SA.adoc to just cover most all of the metadata variables. If this is accepted/usable, then I will likely do another PR to update the product versions across the kubernetes reference files and even add more content in this space as well.
@bwgartner
Hi Bryan! Unfortunately I cannot merge this PR. Several validation checks failed, and it looks to me as if there are issues with some titles. Tom is out this week, and only back next week - I assume we need his help with the investigations where we have issues, and if the rest (of metadata) is okay.
Also, would you mind rebasing or updating your branch to the the latest main - this will also help to avoid merge conflicts.
I think Tom is back on Tuesday - I will ask him to have a look at the PR as soon as he finds time.
@bwgartner Looking at the GitHub Action I see a lot of those error messages:
asciidoctor: WARNING: skipping reference to missing attribute: title
You are probably already aware that this is some issue with the AD source code. Sounds to me like there are some if clauses that caused the :title: attribute to be NOT defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated only the kubernetes reference files ... adoc/docinfo.xml and adoc/SA_vars.adoc and adoc/SA.adoc to just cover most all of the metadata variables. If this is accepted/usable, then I will likely do another PR to update the product versions across the kubernetes reference files and even add more content in this space as well.