Implement new kem::Kem trait
#223
Merged
+337
−373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
impl-kem-trait
branch
3 times, most recently
from
0f1c49b to
7eb650e
Compare
tarcieri
force-pushed
the
impl-kem-trait
branch
5 times, most recently
from
0642c18 to
44c641e
Compare
Companion PR to RustCrypto/traits#2243 This implements a trait which describes a whole KEM type family, with a similar shape to the former `dhkem::DhKem` and `ml_kem::KemCore` traits (both of which have been removed and replaced with `kem::Kem`). As part of this, the `*Params` types in `ml_kem` have been merged with the former type aliases of the `ml_kem::Kem` type (which have also been removed), and now `MlKem512`, `MlKem768`, and `MlKem1024` are the one true ZSTs for describing ML-KEM parameters.
tarcieri
force-pushed
the
impl-kem-trait
branch
from
44c641e to
28e8481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to RustCrypto/traits#2243
This implements a trait which describes a whole KEM type family, with a similar shape to the former
dhkem::DhKemandml_kem::KemCoretraits (both of which have been removed and replaced withkem::Kem).As part of this, the
*Paramstypes inml_kemhave been merged with the former type aliases of theml_kem::Kemtype (which have also been removed), and nowMlKem512,MlKem768, andMlKem1024are the one true ZSTs for describing ML-KEM parameters.