Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors various neural network classes to use the NumPower library. It introduces new implementations for neural network layers, networks, snapshots, and their corresponding test files. The changes also update documentation paths to reflect the new class structure organized into subdirectories.
Changes:
- Adds new neural network layer implementations (Dense, Activation, Binary, Continuous, Multiclass, Dropout, Noise, BatchNorm, PReLU, Swish, Placeholder1D) using NumPower
- Introduces Network and FeedForward classes with comprehensive test coverage
- Updates initializers to include explicit
locparameter for NumPower compatibility - Updates documentation paths to reflect new directory structure
Reviewed changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/NeuralNet/Networks/Network.php | New base Network class implementation using NumPower |
| src/NeuralNet/FeedForwards/FeedForward.php | New FeedForward network extending Network |
| src/NeuralNet/Layers//.php | New layer implementations (Dense, Activation, Binary, etc.) |
| src/NeuralNet/Snapshots/Snapshot.php | New snapshot class for network state management |
| tests/NeuralNet//.php | Comprehensive test coverage for new implementations |
| src/NeuralNet/Initializers//.php | Updated to include explicit loc parameter |
| docs/neural-network/hidden-layers/*.md | Documentation path updates |
| phpunit.xml | Memory limit increase for tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hey @apphp I;m a little confused because I'm seeing some Neural Net layers in this PR and I thought those were handled in a separate PR. |
|
@andrewdalpino - this PR is based on previous PR #393 |
No description provided.