[FIX] Limit Top Posts Count in Discourse Module #73
Open
samad-yar-khan wants to merge 2 commits intoRocketChat:mainfrom
Open
[FIX] Limit Top Posts Count in Discourse Module #73samad-yar-khan wants to merge 2 commits intoRocketChat:mainfrom
samad-yar-khan wants to merge 2 commits intoRocketChat:mainfrom
Conversation
Contributor
Author
|
@RonLek @Sing-Li I have made the changes and have locally tested updating the data (with some dummy data) to maintain the top N posts only. Have also made sure that if the same post is fetched again, then it is not stored again in database. By default strapi will fetch posts in the order in which they are created. Hence, we delete the first X excess/stale posts and add our new TopPost to the CMS database after that. Let me know if there are any changes 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Fixes : #21