[On Hold - Dec 22] Pre commit hooks#51
Open
sidmohanty11 wants to merge 2 commits intoRocketChat:mainfrom
Open
Conversation
Contributor
sidmohanty11
commented
Jan 25, 2022
- added necessary pre-commit hooks mentioned in the issue #49 under ./githooks
- added a .pre-commit-config.yaml file where we can modify any configuration of the hooks
- added a make script that shall be run to enable these hooks to run, ref: https://www.viget.com/articles/two-ways-to-share-git-hooks-with-your-team/
Member
|
Why not use husky? Our main repo already uses it. https://github.com/RocketChat/Rocket.Chat/blob/develop/.husky/pre-push |
Contributor
Author
|
@debdutdeb we could totally do that, I've added this according to the issue description but let me know if we want to use husky instead |
Sing-Li
requested changes
Jan 25, 2022
Member
Sing-Li
left a comment
There was a problem hiding this comment.
Thanks for the contrib.
Pre commit hooks are #1 deterrent to new contributors and bain of bad dev experience (turning many away from our main repo).
At this early stage of our project, we need to keep the onramp simple to attract more contributors and users.
We don't need it yet. Let's revisit this in June.
Member
|
Please focus your energy on the huge list of project contents TODOs instead of adding project infra elements. |
Contributor
Author
|
Sure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.