[NEW] dummy auth model by sidmohanty11 · Pull Request #171 · RocketChat/RC4Community

sidmohanty11 · 2022-06-17T17:25:49Z

This PR introduces,

a dummy authentication model
removes firebase error
fixes all the console errors for a smooth development experience

Fixes #156

sidmohanty11 · 2022-06-17T17:27:11Z

Dummy User Authentication Model

dummy_auth.mp4

lgtm-com · 2022-06-17T17:28:15Z

This pull request fixes 1 alert when merging c09a95e into 13b5926 - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

lgtm-com · 2022-07-03T13:06:39Z

This pull request fixes 1 alert when merging 6525635 into b142610 - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

sidmohanty11 · 2022-07-03T13:08:52Z

I've fixed almost all errors that were arising:

firebase error
slideCount error

There remains only one error (<button> inside <button>) which is coming from the Menubar component because we are using Navbar.Toggle but inside for styling, we are using another button. This should be fixed with the new Menubar component which is being worked on in this PR.

app/lib/auth/RocketChatOAuthProvider.js

debdutdeb · 2022-07-03T18:30:45Z

app/pages/api/auth/[...nextauth].js

+				clientId: process.env.ROCKETCHAT_CLIENT_ID ?? "random",
+				clientSecret: process.env.ROCKETCHAT_CLIENT_SECRET ?? "random",
+				rocketChatUrl: process.env.ROCKETCHAT_URL ?? "http://localhost:3000"


Make sure empty strings aren't an issue here.

app/components/auth/dummy/ui/DummyLoginButton.js

app/components/auth/dummy/lib/function.js

debdutdeb · 2022-07-03T18:53:15Z

app/components/auth/dummy/ui/DummyLoginUI.js

+  const login = () => {
+    const dummy_user = dummyUserLogin();
+    setUser(dummy_user);
+    sessionStorage.setItem("dummy_user", JSON.stringify(dummy_user));
+  }
+  const logout = () => {
+    setUser({});
+    sessionStorage.removeItem("dummy_user");
+  }


Move these to DummyLoginButton and just pass the user state. Pass these as handleLogin and handleLogout.

app/components/auth/dummy/ui/DummyLoginUI.js

app/components/menubar.js

lgtm-com · 2022-07-04T19:22:21Z

This pull request fixes 1 alert when merging f96a1d5 into 53d9c3d - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

Sing-Li

Works well @sidmohanty11 But what happened to the menu/TopNav? It would be good to have the menu change depending on the logged in state as well.

sidmohanty11 · 2022-07-06T07:35:47Z

It is there in my case.

Is it due to cms uninitialized? But that should break the app, right? Can you check with running cms?

Sing-Li · 2022-07-07T15:35:25Z

cms definitely initialized - otherwise there will be no element live. can you verify with a clean clone? I think you may have something added that has not been committed or initialized? @sidmohanty11 thx

debdutdeb · 2022-07-07T16:42:47Z

app/components/auth/dummy/lib/function.js

+const createDummyUser = () => {
+  return {
+    id: 1,
+    name: "dummy.cat",
+    image:
+      "https://user-images.githubusercontent.com/25859075/29918905-88dcc646-8e5c-11e7-81ec-242bc58dce1b.jpg",
+    email: "dummyuser@rocket.chat",
+    emailVerified: false,
+    phoneNumber: null,
+    displayName: "dummy.cat",
+  };
+};
+
+export const dummyUserLogin = () => {
+  return createDummyUser();
+};


You can get rid of dummyUserLogin btw 👀

debdutdeb · 2022-07-07T16:45:24Z

app/components/menubar.js

+          {userCookie ? (
+            <Dropdown align="end" className={styles.dropdown_menu}>
+              <Dropdown.Toggle as={CustomToggle} />
+              <Dropdown.Menu size="sm" title="">
+                <Dropdown.Header>RC4Community Profile</Dropdown.Header>
+                <Dropdown.Item>
+                  <Link href={`/profile/${userCookie}`}>
+                    <a className={styles.dropdown_menu_item}>Profile</a>
+                  </Link>
+                </Dropdown.Item>
+              </Dropdown.Menu>
+            </Dropdown>
+          ) : (
+            ""
+          )}


Suggested change

{userCookie ? (

<Dropdown align="end" className={styles.dropdown_menu}>

<Dropdown.Toggle as={CustomToggle} />

<Dropdown.Menu size="sm" title="">

<Dropdown.Header>RC4Community Profile</Dropdown.Header>

<Dropdown.Item>

<Link href={`/profile/${userCookie}`}>

<a className={styles.dropdown_menu_item}>Profile</a>

</Link>

</Dropdown.Item>

</Dropdown.Menu>

</Dropdown>

) : (

""

)}

{userCookie && (

<Dropdown align="end" className={styles.dropdown_menu}>

<Dropdown.Toggle as={CustomToggle} />

<Dropdown.Menu size="sm" title="">

<Dropdown.Header>RC4Community Profile</Dropdown.Header>

<Dropdown.Item>

<Link href={`/profile/${userCookie}`}>

<a className={styles.dropdown_menu_item}>Profile</a>

</Link>

</Dropdown.Item>

</Dropdown.Menu>

</Dropdown>

)}

debdutdeb · 2022-07-07T16:47:06Z

app/components/auth/dummy/ui/DummyLoginUI.js

+  const handleLogin = () => {
+    const dummy_user = dummyUserLogin();
+    setUser(dummy_user);
+    sessionStorage.setItem("dummy_user", JSON.stringify(dummy_user));
+  };
+  const handleLogout = () => {
+    setUser({});
+    sessionStorage.removeItem("dummy_user");
+  };


Move to main component and pass them here. Mentioned this in the previous review, adding here to put it to the top. But, see my other comment on state.

debdutdeb · 2022-07-07T16:48:55Z

app/components/auth/dummy/ui/DummyLoginButton.js

+  const [isLoginUiOpen, setIsLoginUiOpen] = useState(false);
+  const [user, setUser] = useState({});
+
+  useEffect(() => {
+      const isStoredInSession = JSON.parse(sessionStorage.getItem("dummy_user"));
+      if (isStoredInSession) {
+          setUser(isStoredInSession);
+      }
+  },[])


As you're getting deeper into react, with this AND your gsoc project, try to advance your practical skills. Convert this to a custom hook like useAuth :) or useDummyAuth (prefer this name). Perfect situation to do that IMO.

Move all createDummyUser or validation functions in the same file.

Great idea! Ah, I just went with the conventional code structure of other auths. I will make the changes!

lgtm-com · 2022-07-09T07:29:16Z

This pull request fixes 1 alert when merging fdfcf4c into 53d9c3d - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

sidmohanty11 · 2022-07-09T07:40:08Z

Did a clean clone and install, the top nav works for me.

closes RocketChat#156

new: dummy auth model with some other fixes

c09a95e

fix: firebase err and slideCount err

6525635

sidmohanty11 changed the title ~~[WIP] dummy auth model~~ [NEW] dummy auth model Jul 3, 2022

debdutdeb requested changes Jul 3, 2022

View reviewed changes

improving dummyuserauth

f96a1d5

sidmohanty11 requested a review from debdutdeb July 4, 2022 19:21

Sing-Li requested changes Jul 5, 2022

View reviewed changes

sidmohanty11 requested a review from Sing-Li July 6, 2022 07:35

debdutdeb requested changes Jul 7, 2022

View reviewed changes

useDummyAuth hook and moving entire dummyUI to dummyUIBtn

fdfcf4c

sidmohanty11 requested a review from debdutdeb July 9, 2022 07:25

Sing-Li merged commit 38dffd9 into RocketChat:master Jul 14, 2022

Dnouv pushed a commit to Dnouv/RC4Community that referenced this pull request Nov 3, 2022

Add dummy auth model (RocketChat#171)

0e5eda8

closes RocketChat#156

Conversation

sidmohanty11 commented Jun 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sidmohanty11 commented Jun 17, 2022

Dummy User Authentication Model

Uh oh!

lgtm-com bot commented Jun 17, 2022

Uh oh!

lgtm-com bot commented Jul 3, 2022

Uh oh!

sidmohanty11 commented Jul 3, 2022

Uh oh!

Uh oh!

debdutdeb Jul 3, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

debdutdeb Jul 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented Jul 4, 2022

Uh oh!

Sing-Li left a comment

Choose a reason for hiding this comment

Uh oh!

sidmohanty11 commented Jul 6, 2022

Uh oh!

Sing-Li commented Jul 7, 2022

Uh oh!

debdutdeb Jul 7, 2022

Choose a reason for hiding this comment

Uh oh!

debdutdeb Jul 7, 2022

Choose a reason for hiding this comment

Uh oh!

debdutdeb Jul 7, 2022

Choose a reason for hiding this comment

Uh oh!

debdutdeb Jul 7, 2022

Choose a reason for hiding this comment

Uh oh!

debdutdeb Jul 7, 2022

Choose a reason for hiding this comment

Uh oh!

sidmohanty11 Jul 9, 2022

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented Jul 9, 2022

Uh oh!

sidmohanty11 commented Jul 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

sidmohanty11 commented Jun 17, 2022 •

edited

Loading

debdutdeb Jul 3, 2022 •

edited

Loading