[NEW][TR] Add support for key value abstraction#169
Open
Dnouv wants to merge 3 commits intoRocketChat:mainfrom
Open
[NEW][TR] Add support for key value abstraction#169Dnouv wants to merge 3 commits intoRocketChat:mainfrom
Dnouv wants to merge 3 commits intoRocketChat:mainfrom
Conversation
Dnouv
changed the title
|
This pull request introduces 1 alert when merging 1198aa0 into 53d9c3d - view on LGTM.com new alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the key-value-like functions aka in this case custom hooks. So now we only have to use the function
callSuper("nft", data), here thenftis the key anddatawould be the value.Thank you!
@RonLek please let me know if this is how it should work.