[IMPROVE] refactor hard-coded component data into parameters (react component props)#145
Open
nishant23122000 wants to merge 8 commits intoRocketChat:mainfrom
Open
[IMPROVE] refactor hard-coded component data into parameters (react component props)#145nishant23122000 wants to merge 8 commits intoRocketChat:mainfrom
nishant23122000 wants to merge 8 commits intoRocketChat:mainfrom
Conversation
|
|
|
This pull request introduces 1 alert and fixes 1 when merging 21704ff into 6dbe41c - view on LGTM.com new alerts:
fixed alerts:
|
debdutdeb
requested changes
Apr 16, 2022
Member
debdutdeb
left a comment
debdutdeb
left a comment
There was a problem hiding this comment.
leaving some notes on my initial look. Will take an actual deeper look later. Thanks.
|
This pull request fixes 1 alert when merging d77d437 into 65fbcd3 - view on LGTM.com fixed alerts:
|
Contributor
Author
1. added counters,infotiles,discourse json files inside initialData. so when user set INITIALIZE_DATA=true,it will add data into strapi collections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put all Hardcoded content outside of component in app/data folder and improved the responsiveness of Infotiles and carousel component by adding media query.
Reference : #77