[FIX] Hide Jitsi Logs using showLogs props#132
Open
samad-yar-khan wants to merge 6 commits intoRocketChat:mainfrom
Open
[FIX] Hide Jitsi Logs using showLogs props#132samad-yar-khan wants to merge 6 commits intoRocketChat:mainfrom
showLogs props#132samad-yar-khan wants to merge 6 commits intoRocketChat:mainfrom
Conversation
|
This pull request introduces 1 alert when merging d7bcd4c into 4db8216 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 8971a74 into 4db8216 - view on LGTM.com new alerts:
|
Sing-Li
requested changes
Apr 5, 2022
Member
There was a problem hiding this comment.
showLogs shouldn't be a constant in the components code!
Contributor
Author
There was a problem hiding this comment.
@Sing-Li I have changed the approach. The logs can now be toggled using a button in the dropdown.
samad-yar-khan
changed the title
showLogs props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Mentioned in the issue #131
Proposed changes (including videos or screenshots)
showLogsprops top<Jitsibroadcaster ... />component which can be set to true to view logs and false to hide logs2022-04-06.12-32-42.mp4