[NEW] Announcement component#114
Open
samad-yar-khan wants to merge 11 commits intoRocketChat:mainfrom
Open
Conversation
3ebadf8 to
869f6c8
Compare
debdutdeb
requested changes
Apr 3, 2022
Member
debdutdeb
left a comment
There was a problem hiding this comment.
Please check why the build is failing.
f90f003 to
ad09104
Compare
Contributor
Author
|
@debdutdeb I have rebased the branch with the master branch and there are no more build errors. Build is not failing anymore 😅 |
ad09104 to
ac4cfaa
Compare
ac4cfaa to
1435a0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Mentioned in the issue #113
Proposed changes (including videos or screenshots)
getAnnouncementData('announcement_code').announcementis fetched usinggetAnnouncementData('announcement_code')code function and passed in the page props.announcementcollection type / schema to store announcements in the database.deleteOldAnnouncemts()helper function as a cron job which will run once a day and will delete any announcements which are supposed to be unpublished depending on the date. This will ensure that unwanted announcements do not clutter the database.cms/config/initialData/announcemnets.jsonwill populate the data base.2022-03-30.22-24-46.mp4