Conversation
debdutdeb
requested changes
Aug 4, 2022
commands/DebugCommand.ts
Outdated
| import { BlockBuilder, TextObjectType } from "@rocket.chat/apps-engine/definition/uikit"; | ||
| import { IUser } from "@rocket.chat/apps-engine/definition/users"; | ||
|
|
||
| // I know i can use the app logger but i like this. |
Member
There was a problem hiding this comment.
Remove this please. This is a serious project, we don't want to commit any staging resources here.
commands/HelpCommand.ts
Outdated
| import { IUser } from "@rocket.chat/apps-engine/definition/users"; | ||
|
|
||
| export class HelpCommand implements ISlashCommand { | ||
| public command = "helpmeet"; |
Member
There was a problem hiding this comment.
A slashcommand for showing help message? Why?
| import { IUser } from "@rocket.chat/apps-engine/definition/users"; | ||
| import { getMeetingUrl } from "../functions/getMeetingUrl"; | ||
|
|
||
| export class JoinCommand implements ISlashCommand { |
commands/Meet.ts
Outdated
| await modify.getScheduler().scheduleRecurring({ | ||
| id: `${commandroom.slugifiedName}`, | ||
| // interval: `${mins} ${hrs} * * ${dayind}`, | ||
| interval: '20 seconds', |
Member
There was a problem hiding this comment.
This is your test code. Neither appropriate to commit nor part of the scope of this PR.
Member
There was a problem hiding this comment.
neither is this part of the pr scope.
| @@ -0,0 +1,33 @@ | |||
| import { IProcessor } from "@rocket.chat/apps-engine/definition/scheduler"; | |||
| @@ -0,0 +1,23 @@ | |||
| import { IHttp, IModify, IPersistence, IRead } from "@rocket.chat/apps-engine/definition/accessors" | |||
commands/StopReminder.ts
Outdated
| @@ -0,0 +1,58 @@ | |||
| // import { IRead, IModify, IHttp, IPersistence, IModifyCreator, IMessageBuilder } from "@rocket.chat/apps-engine/definition/accessors"; | |||
| @@ -0,0 +1,83 @@ | |||
| import { IRead, IModify, IHttp, IPersistence, IModifyCreator, IMessageBuilder, ILogger } from "@rocket.chat/apps-engine/definition/accessors"; | |||
| import { multipleProcessors } from './reminder/processors/multipleProcessors'; | ||
| import { weeklyNotification } from './reminder/processors/weeklyNotification'; | ||
| import { AppSettings } from './settings/appsettings'; | ||
| import { BbbSettings } from './settings/bbbsettings'; |
Member
There was a problem hiding this comment.
You need to clean up the imports.
BbbMeetApp.ts
Outdated
Comment on lines
48
to
49
| await configuration.slashCommands.provideSlashCommand(new ScheduleMeetCommand()) | ||
| await configuration.slashCommands.provideSlashCommand(new MeetCommand()) |
Member
There was a problem hiding this comment.
You are not registering the command that this PR is about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app settings will have a setting which will be a string of room names which are supposed to be the meeting channels where the join command will work. When the join command is called: