Feat/add new dashboard UI by manish591 · Pull Request #299 · RealDevSquad/website-crypto

manish591 · 2022-12-22T16:54:39Z

fixes #272

NOTE: I have taken a pull from Vinayak's PR #274 that is already been reviewed.

Visual Reference

* Changes in navbar UI and content * Change in navbar UI * Change in navbar UI as per new design * Add login url from constants * Added changes to fetch and display data for signed-in users * Fixed display data for signed-out users * Added mobile UI change for currency exchange page * Added changes to use Link component for anchor tags * Remove commented code * css code refactor changes * Add and load paths from constants file * Remove !important property from navbar css * Refactor css code * Add UI changes in navbar * Add default avatar for user profile picture * Add UI changes in navbar * Add UI changes in navbar * Add profile link on greet message & error handling in fetch user * Fix profile url * Added .env.development file (RealDevSquad#245) Co-authored-by: user.name: "Rohan Raj Gupta <user.email: "rajrohan1914@gmail.com> * Improvement in code and changes to use cloudinary images * Add key prop * Replace useEffect by useLayoutEffect for login button * Improvement in navbar code * Update ecmaVersion in ESLint config * Revert useLayoutEffect changes for login button * Fix login button UI Co-authored-by: Shubham <yadav105shubham@gmail.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: user.name: "Rohan Raj Gupta <user.email: "rajrohan1914@gmail.com>

…bsite-crypto into feature/new-sidebar

vercel · 2022-12-22T16:54:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
website-crypto	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 18, 2023 at 5:45PM (UTC)

components/Sidebar/index.jsx

components/breadcrumbs/index.js

components/currency-card/index.js

components/chart-actions/index.js

components/profile-sidebar/index.js

heyrandhir · 2023-01-30T01:43:04Z

@manish591 can't find the test in the PR. Are the test already merged 🤔.

manish591 · 2023-02-03T18:42:44Z

@manish591 can't find the test in the PR. Are the test already merged 🤔.

No, the tests are not merged yet. Will write them now

components/Sidebar/index.jsx

components/transaction-chart/transaction-chart.module.css

pages/dashboard/index.js

samyakshah3008

Solid work Manish!

Here are few pointers which you can refactor:

Instead of using px, use rem.
Don't use !important
Avoid white spaces

Added few single line comments, rest is all good for approval.

components/Sidebar/sidebar.module.css

components/chart-actions/index.js

styles/globals.css

heyrandhir

Great work @manish591! .Would recommend you creating small and incremental PRs in the future. Thank you!

manish591 · 2023-03-26T08:27:20Z

Great work @manish591! .Would recommend you creating small and incremental PRs in the future. Thank you!

ok

graphite-app · 2025-05-29T15:39:27Z

components/Sidebar/sidebar.module.css

+    display: flex;
+    justify-content: space-between;
+    padding: 1.6rem;
+    background-color: var(---bg-blue-300);


There appears to be a CSS variable name typo in the sidebar mobile toggle styling. The property background-color: var(---bg-blue-300); has an extra dash - it should be background-color: var(--bg-blue-300); (with two dashes instead of three). This will ensure the mobile toggle background color renders correctly.

Suggested change

background-color: var(---bg-blue-300);

background-color: var(--bg-blue-300);

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2025-05-29T15:39:28Z

constants/sidebarMenuIconPaths.js

@@ -0,0 +1,5 @@
+export default {
+  ICON_PATH_ARROW: '/assets/rrow.svg',


There appears to be a typo in the icon path for the arrow. The current path is '/assets/rrow.svg' but should likely be '/assets/arrow.svg' or '/assets/MenuArrow.svg' (which exists in the public assets directory based on the PR). This could cause the arrow icon to not load properly in the UI.

Suggested change

ICON_PATH_ARROW: '/assets/rrow.svg',

ICON_PATH_ARROW: '/assets/MenuArrow.svg',

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2025-05-29T15:39:30Z

constants/months.js

+  'June',
+  'July',
+  'August',
+  'Sepetember',


There's a typo in the month name - 'Sepetember' should be spelled 'September'. This appears in the months list constant that's used for the transaction dropdown.

Suggested change

'Sepetember',

'September',

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

akshay1502 and others added 16 commits August 22, 2022 22:42

added contstants and image

0d35066

fixed sidebar files

4d7da41

fixed the sidebar

3e19883

'Requested Changes Done'

f82eed7

fixed typo

5505754

Merge branch 'develop' into feature/new-sidebar

ba14b6c

responsivness added

944e08f

added contstants and image

752bcf2

fixed sidebar files

1a89d49

fixed the sidebar

0a53637

'Requested Changes Done'

def0ffb

fixed typo

72bd58e

responsivness added

9cbf66b

Merge branch 'feature/new-sidebar' of https://github.com/ivinayakg/we…

125e025

…bsite-crypto into feature/new-sidebar

manish591 marked this pull request as draft December 22, 2022 16:55

feat-created new dashboard UI

d8257de

vercel bot deployed to Preview January 1, 2023 18:33 View deployment

manish591 marked this pull request as ready for review January 11, 2023 19:08

manish591 marked this pull request as draft January 11, 2023 19:11

manish591 marked this pull request as ready for review January 12, 2023 14:51

style-created responsive layout

fb7c4dc

vercel bot deployed to Preview January 28, 2023 12:12 View deployment

heyrandhir suggested changes Jan 30, 2023

View reviewed changes

heyrandhir assigned manish591 Jan 30, 2023

manish591 added 2 commits February 3, 2023 21:36

added remaining months in month dropdown

8aa4c73

removed hardcoded data

bf512e0

vercel bot deployed to Preview February 3, 2023 18:41 View deployment

refactor-requested changes

1af9930

vercel bot deployed to Preview February 6, 2023 15:53 View deployment

style-added cursor property in breadcrumbs

39a0c8c

vercel bot deployed to Preview February 6, 2023 16:11 View deployment

test-tests added for dashboard UI

41adc8e

vercel bot deployed to Preview February 15, 2023 18:50 View deployment

DeRaowl suggested changes Feb 16, 2023

View reviewed changes

samyakshah3008 self-requested a review February 16, 2023 04:20

samyakshah3008 previously approved these changes Feb 18, 2023

View reviewed changes

components/Sidebar/sidebar.module.css Outdated Show resolved Hide resolved

components/Sidebar/sidebar.module.css Outdated Show resolved Hide resolved

components/chart-actions/index.js Outdated Show resolved Hide resolved

styles/globals.css Show resolved Hide resolved

MehulKChaudhari mentioned this pull request Mar 6, 2023

Initial code for dashboard #277

Closed

added requested changes

314ad1c

manish591 dismissed samyakshah3008’s stale review via 314ad1c March 9, 2023 17:35

vercel bot deployed to Preview March 9, 2023 17:36 View deployment

updated tests

94c6705

vercel bot deployed to Preview March 15, 2023 18:36 View deployment

Merge branch 'develop' into feat/add-new-dashboard-UI

bf32a62

vercel bot deployed to Preview March 18, 2023 17:45 View deployment

DeRaowl approved these changes Mar 24, 2023

View reviewed changes

heyrandhir approved these changes Mar 25, 2023

View reviewed changes

graphite-app bot reviewed May 29, 2025

View reviewed changes

	background-color: var(---bg-blue-300);
	background-color: var(--bg-blue-300);

		@@ -0,0 +1,5 @@
		export default {
		ICON_PATH_ARROW: '/assets/rrow.svg',

	ICON_PATH_ARROW: '/assets/rrow.svg',
	ICON_PATH_ARROW: '/assets/MenuArrow.svg',

Conversation

manish591 commented Dec 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual Reference

Uh oh!

vercel bot commented Dec 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

heyrandhir commented Jan 30, 2023

Uh oh!

manish591 commented Feb 3, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samyakshah3008 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

heyrandhir left a comment

Choose a reason for hiding this comment

Uh oh!

manish591 commented Mar 26, 2023

Uh oh!

graphite-app bot May 29, 2025

Choose a reason for hiding this comment

Uh oh!

graphite-app bot May 29, 2025

Choose a reason for hiding this comment

Uh oh!

graphite-app bot May 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

manish591 commented Dec 22, 2022 •

edited

Loading

vercel bot commented Dec 22, 2022 •

edited

Loading