This repository was archived by the owner on May 25, 2020. It is now read-only.
The following changes properly implement page updates so that revisio…#17
Open
brontide wants to merge 1 commit intoRaymiiOrg:masterfrom
Open
The following changes properly implement page updates so that revisio…#17brontide wants to merge 1 commit intoRaymiiOrg:masterfrom
brontide wants to merge 1 commit intoRaymiiOrg:masterfrom
Conversation
…n history is preserved. Parent ID is automatically grabbed from the page so it is no longer required and an optional comment can be added to the update. The code has support for marking it a major update but I have not enabled a way to pass it through from the command line.
dpwolfe
reviewed
Sep 3, 2018
| def update(self,content,parent_id=None, comment = None, minor = True): | ||
| self.logger.debug("Update page '{}'; label = [{}]".format(self.name, self.label)) | ||
| page_update = self.get() | ||
| for key in page_update.keys(): |
There was a problem hiding this comment.
Since the array is being mutated while being iterated, I needed to clone it with a .copy() in there to avoid a runtime error:
for key in page_update.copy().keys():
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n history
is preserved. Parent ID is automatically grabbed from the page so it is no
longer required and an optional comment can be added to the update. The code
has support for marking it a major update but I have not enabled a way to pass
it through from the command line.