[DOC] Make ubuntu precompile dockerfile work for older docker version#433
Open
yansun1996 wants to merge 1 commit intoROCm:release-v1.4.1from
Open
[DOC] Make ubuntu precompile dockerfile work for older docker version#433yansun1996 wants to merge 1 commit intoROCm:release-v1.4.1from
yansun1996 wants to merge 1 commit intoROCm:release-v1.4.1from
Conversation
Signed-off-by: yansun1996 <Yan.Sun3@amd.com>
yansun1996
force-pushed
the
fix_precompile_doc_v1.4.1
branch
from
273795a to
775de5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some older docker version didn't support wildcard match when using
COPYcommand, this PR is updating the pre-compile dockerfile to make it work for both older and latest docker engine.Technical Details
Remove the wildcard match, some docker versions won't support that in
COPYcommand and result in failure during docker build.Test Plan
Test Result
Submission Checklist