fix: wrap errors for proper error chain propagation#99
Open
shiv-tyagi wants to merge 1 commit intoROCm:mainfrom
Open
fix: wrap errors for proper error chain propagation#99shiv-tyagi wants to merge 1 commit intoROCm:mainfrom
shiv-tyagi wants to merge 1 commit intoROCm:mainfrom
Conversation
shiv-tyagi
force-pushed
the
fix-error-propagation
branch
from
948c661 to
bfe32f4
Compare
We should not just print on console and return the error as-is to upstream but rather wrap it with context and then propagate it. This is a standard golang practice.
shiv-tyagi
force-pushed
the
fix-error-propagation
branch
from
bfe32f4 to
29a0b93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not just print on console and return the error as-is to upstream but rather wrap it with context and then propagate it. This is a standard golang practice.