Skip to content

Conversation

@SamiAario-AMD
Copy link
Contributor

@SamiAario-AMD SamiAario-AMD commented Jan 27, 2026

Proposed changes

The SmallM and MidLargeM fp16 x pkint4 tests were failing previously for K size 2*KTile. These tests now pass locally on gfx950. Remove the checks that skip these previously failing test cases.

Checklist

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

@SamiAario-AMD SamiAario-AMD force-pushed the re-enable-two-fp16-x-pkint4-tests branch from 27c30ac to 79a23ff Compare January 27, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants