test: Add umbrella test targets for CK Tile operations #3654
Conversation
AviralGoelAMD
requested review from
a team,
Snektron,
ThomasNing,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
ddembeckAMD,
geyyer,
illsilin,
poyenc,
qianfengz,
shumway,
tenpercent,
vidyasagar-amd and
vpietila-amd
as code owners
There was a problem hiding this comment.
Pull request overview
This PR introduces operation-specific umbrella test targets for CK Tile to enable running all tests for a specific operation (e.g., GEMM, FMHA, reduce) without running the entire test suite. This improves the development workflow by allowing faster iteration when working on specific operations.
Changes:
- Added umbrella test targets for six CK Tile operations: GEMM, GEMM block scale, GEMM StreamK, grouped GEMM quantization, FMHA, and reduce
- Created comprehensive testing documentation in
test/ck_tile/README.md - Modified existing CMakeLists.txt files to support the new test targets while preserving existing build targets
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/ck_tile/CMakeLists.txt | Added documentation header explaining the three-tier test organization system |
| test/ck_tile/README.md | New comprehensive testing guide with usage examples for all test targets |
| test/ck_tile/gemm/CMakeLists.txt | Added ck_tile_gemm_tests umbrella target with test collection and labeling |
| test/ck_tile/gemm_block_scale/CMakeLists.txt | Added ck_tile_gemm_block_scale_tests target and refactored existing test organization |
| test/ck_tile/gemm_streamk/CMakeLists.txt | Added ck_tile_gemm_streamk_tests umbrella target |
| test/ck_tile/grouped_gemm_quant/CMakeLists.txt | Added ck_tile_grouped_gemm_quant_tests umbrella target |
| test/ck_tile/fmha/CMakeLists.txt | Added ck_tile_fmha_tests target and updated test labeling in helper functions |
| test/ck_tile/reduce/CMakeLists.txt | Added ck_tile_reduce_tests umbrella target |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| endforeach() | ||
| message(STATUS "FMHA FWD tests: ${all_tests}") | ||
| add_custom_target(${test_group} DEPENDS ${all_tests}) | ||
| set(all_tests ${all_tests} PARENT_SCOPE) |
There was a problem hiding this comment.
The all_tests variable is set to PARENT_SCOPE in both add_gtest_fwd and add_gtest_bwd functions, but these will overwrite each other rather than accumulate. The second call will only contain the BWD tests. If the intent is to collect all tests from both functions, you need to accumulate them in the parent scope or handle them differently.
| endforeach() | ||
| message(STATUS "FMHA BWD tests: ${all_tests}") | ||
| add_custom_target(${test_group} DEPENDS ${all_tests}) | ||
| set(all_tests ${all_tests} PARENT_SCOPE) |
There was a problem hiding this comment.
The all_tests variable is set to PARENT_SCOPE in both add_gtest_fwd and add_gtest_bwd functions, but these will overwrite each other rather than accumulate. The second call will only contain the BWD tests. If the intent is to collect all tests from both functions, you need to accumulate them in the parent scope or handle them differently.
Proposed changes
Adds operation-specific umbrella test targets for CK Tile to enable running all tests for a specific operation without running the entire test suite. This improves the development workflow by allowing faster iteration when working on specific operations.
Motivation
Previously, developers working on CK Tile operations could only:
smoke,regression,check) which test the entire codebaseThis made it cumbersome to validate changes to a specific operation (e.g., GEMM quantization) without either running tests individually or running the entire test suite.
Documentation
test/ck_tile/TESTING.md- Comprehensive testing guide with usage examples and implementation detailsUsage Examples
Run all GEMM tests with 256 parallel jobs
ninja -j256 ck_tile_gemm_tests
Run all GEMM block scale (quantization) tests
ninja -j256 ck_tile_gemm_block_scale_tests
Run all GEMM StreamK tests
ninja -j256 ck_tile_gemm_streamk_tests
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered