Update amd-smi set -M NPS4 example output#81
Merged
peterjunpark merged 1 commit intodevelopfrom Jan 28, 2026
Merged
Conversation
gabrpham
requested changes
Jan 28, 2026
gabrpham
left a comment
gabrpham
left a comment
There was a problem hiding this comment.
Just one last change here. We took out amd-smi reset -r and want people to just use sudo modprobe -r amdgpu and sudo modprobe amdgpu now.
gabrpham
approved these changes
Jan 28, 2026
gabrpham
left a comment
gabrpham
left a comment
There was a problem hiding this comment.
Previous review comment was made in error. Everything here is correct now. Thanks!
amitkumar-amd
approved these changes
Jan 28, 2026
peterjunpark
added a commit
that referenced
this pull request
Jan 28, 2026
(cherry picked from commit 862a223)
peterjunpark
added a commit
that referenced
this pull request
Jan 28, 2026
(cherry picked from commit 862a223)
peterjunpark
added a commit
that referenced
this pull request
Jan 28, 2026
(cherry picked from commit 862a223)
peterjunpark
added a commit
that referenced
this pull request
Jan 28, 2026
(cherry picked from commit 862a223)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Address @gabrpham 's comments in #80
Technical Details
Test Plan
Test Result
Submission Checklist