Skip to content

Small fixes for upstream + CUDA#366

Merged
kshyatt merged 6 commits intomainfrom
ksh/cuda_tweaks
Feb 6, 2026
Merged

Small fixes for upstream + CUDA#366
kshyatt merged 6 commits intomainfrom
ksh/cuda_tweaks

Conversation

@kshyatt
Copy link
Member

@kshyatt kshyatt commented Feb 6, 2026

Need these for various ops in PEPSKit

@kshyatt kshyatt requested a review from lkdvos February 6, 2026 10:29
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Your PR no longer requires formatting changes. Thank you for your contribution!

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
ext/TensorKitChainRulesCoreExt/linalg.jl 100.00% <100.00%> (ø)
src/tensors/tensor.jl 85.47% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments, otherwise looks great!

kshyatt and others added 3 commits February 6, 2026 15:37
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
lkdvos
lkdvos previously approved these changes Feb 6, 2026
@kshyatt kshyatt enabled auto-merge (squash) February 6, 2026 14:57
Jutho
Jutho previously approved these changes Feb 6, 2026
@lkdvos
Copy link
Member

lkdvos commented Feb 6, 2026

It looks like there is a missing unthunk in my scale!! suggestion, apologies for that!

@kshyatt kshyatt dismissed stale reviews from Jutho and lkdvos via ad9a324 February 6, 2026 16:04
@kshyatt kshyatt merged commit 4e22032 into main Feb 6, 2026
42 checks passed
@kshyatt kshyatt deleted the ksh/cuda_tweaks branch February 6, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants