Multithreaded implementations using OhMyThreads#117
Draft
Conversation
This is necessary because of OhMyThreads.jl
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 81.46% 81.59% +0.13%
==========================================
Files 42 42
Lines 5588 5574 -14
==========================================
- Hits 4552 4548 -4
+ Misses 1036 1026 -10 ☔ View full report in Codecov by Sentry. |
Member
|
Maybe the
In principle, the scheduler keyword argument should also be added to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt at providing a unifying interface for various multi-threaded approaches to looping over blocksectors, and looping over fusiontrees.
It can be controlled through the
schedulerkwarg in various places, upon which OhMyThreads dispatches, such that there is a possibility of creating and experimenting with scheduler types if one so pleases.By default, there is
default_scheduler(tensortype))=SerialScheduler(), which just mimicks the non-multithreaded approaches at minimal overhead.Various built-in schedulers exist for OhMyThreads, with Greedy, Dynamic or Static schemes, each with up- and downsides depending on the specific case as well as spacetypes. The hope is that this allows a flexible approach that enables users to tweak these settings if they so please, without having to deal with this when this is not necessary.
To do: