-
Notifications
You must be signed in to change notification settings - Fork 54
DEA cost for Fischer-Tropsch, methanolisation #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
euronion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestions. There are a few things I have to ask you to recheck!
for more information, see https://pre-commit.ci
|
@euronion I made the updates, please have a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one or two things to double-check (and re-run csv creation).
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
|
Only some polishing left |
euronion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
Closes # (if applicable).
Changes proposed in this Pull Request
Changing from Agora values for methanolisation, Fischer-Tropsch and methanation to DEA values.
Checklist
doc.environment.yaml(if applicable).doc/release_notes.rstof the upcoming release is included.