Skip to content

Conversation

@millingermarkus
Copy link
Contributor

Closes # (if applicable).

Changes proposed in this Pull Request

Changing from Agora values for methanolisation, Fischer-Tropsch and methanation to DEA values.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Data source for new technologies is clearly stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the GPLv3 license.

Copy link
Collaborator

@euronion euronion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions. There are a few things I have to ask you to recheck!

@euronion euronion linked an issue Sep 17, 2025 that may be closed by this pull request
@millingermarkus
Copy link
Contributor Author

@euronion I made the updates, please have a look!

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one or two things to double-check (and re-run csv creation).

millingermarkus and others added 3 commits November 3, 2025 14:24
@euronion
Copy link
Collaborator

Only some polishing left

@millingermarkus
Copy link
Contributor Author

Now it should be good to go! Sorry for the unintended changes. Thanks @euronion and @fneum for the thorough check!

Copy link
Collaborator

@euronion euronion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@fneum fneum mentioned this pull request Feb 12, 2026
5 tasks
@fneum fneum merged commit c30f489 into PyPSA:master Feb 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to DEA for Fischer-Tropsch and Methanol

3 participants