Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the deck dimensions for Hamilton STAR and STARlet systems to reflect their actual working deck sizes, excluding the rightmost waste block area. The changes ensure that deck size calculations are consistent with the usable rail space for labware placement.
Changes:
- Reduced
STARLET_SIZE_Xfrom 1360mm to 1005mm andSTAR_SIZE_Xfrom 1900mm to 1545mm to reflect actual deck dimensions - Refactored trash positioning to be relative to the waste block location instead of using a hardcoded offset from the right edge
- Added
with_waste_blockparameter to control waste block creation independently of teaching rack
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pylabrobot/resources/hamilton/hamilton_decks.py | Updated STAR/STARlet deck size constants, refactored trash/waste block initialization order, and excluded Trash from collision detection |
| pylabrobot/resources/deck.py | Updated default deck size_x to match new STARlet dimensions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| def serialize(self) -> dict: | ||
| return { | ||
| **super().serialize(), | ||
| "with_waste_block": False, # data encoded as child. (not very pretty to have this key though...) |
There was a problem hiding this comment.
The serialized value for with_waste_block should reflect the actual parameter value passed to __init__, not be hardcoded to False. This will cause incorrect deserialization when the deck was created with with_waste_block=True.
| "with_waste_block": False, # data encoded as child. (not very pretty to have this key though...) | |
| "with_waste_block": any(child.name == "waste_block" for child in self.children), |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 participant
No description provided.