Open
Conversation
added 6 commits
February 28, 2014 10:04
Extend the Sendgrid event handler to process all events received from Sendgrid (using the Event Webhook v3 API). This includes email views, email clicks, unsubscribes, spam reports, and bounces. The endpoint uses basic auth to provide a bit of protection against attack. The username and password are set in the SENDGRID_USER and SENDGRID_PASSWORD environment variables respectively. They default to sendgrid (both username and password) if not set. When configuring Sendgrid these parameters must be set as described in the Sendgrid documentation. All event processing goes via delayed job to even out load. If you use Platform's event tracking this can lead to double counting. There isn't a general solution to this as multiple opens, views, etc. are valid. However, double counting isn't likely to make much difference in practice.
credentials The SendGrid event handler was reusing the SendGrid API credentials. I decided this was a bad idea and it should have its own credentials, as they will probably be less secure.
For greater insight into what is happening with event processing, track events and errors with New Relic custom metric under the Custom/SendgridEvent path.
SendGrid has flattened their JSON format for events. Match that change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the Sendgrid event handler to process all events received from
Sendgrid (using the Event Webhook v3 API). This includes email views,
email clicks, unsubscribes, spam reports, and bounces.
The endpoint uses basic auth to provide a bit of protection against
attack. The username and password are set in the SENDGRID_USER and
SENDGRID_PASSWORD environment variables respectively. They default to
sendgrid (both username and password) if not set. When configuring
Sendgrid these parameters must be set as described in the Sendgrid
documentation.
All event processing goes via delayed job to even out load.
If you use Platform's event tracking this can lead to double
counting. There isn't a general solution to this as multiple opens,
views, etc. are valid. However, double counting isn't likely to
make much difference in practice.