Conversation
| ); | ||
|
|
||
| calldatas[calldataIndex++] = | ||
| abi.encodeCall(AccessManager.grantRole, (ORACLE_ROLE_ID, accessManagerConfiguration.admin, 0)); |
There was a problem hiding this comment.
oracle role to admin? also it is not assigned to any function. Will it be used externally?
There was a problem hiding this comment.
I think it should be assigned to the setValidatorsETH but it's not part of the interface
| console.log("Vault:", accessManagerConfiguration.vault); | ||
| console.logBytes(customExternalCallData); | ||
|
|
||
| // TODO: Custom external call directly to the beacon deposit contract |
There was a problem hiding this comment.
Can we remove all the commented code and TODO?
|
May I suggest having a roles-config-files dir and having a file per institution (like matrix.json)? And passing the path to the CustomExternalCallNonRestakingValidators and InitialAccessManagerSetup scripts. If we plan on creating vaults for several institutions might be tidier |
|
Also a proper README file would be useful |
| uint64 public constant ADMIN_ROLE_ID = type(uint64).min; // 0 | ||
| uint64 public constant DEPOSITOR_ROLE_ID = 1; | ||
| uint64 public constant WITHDRAWER_ROLE_ID = 2; | ||
| uint64 public constant CUSTOM_EXTERNAL_CALLER_ROLE_ID = 3; | ||
| uint64 public constant WITHDRAWAL_MANAGER_ROLE_ID = 4; | ||
| uint64 public constant ORACLE_ROLE_ID = 5; |
There was a problem hiding this comment.
maybe move the roles to its own file to make it more manageable
4 participants
No description provided.