fixed empty ongoing-anime list(#10)#16
Open
singhayushh wants to merge 1 commit intoProjectSakura:masterfrom
singhayushh:issue-10
Open
fixed empty ongoing-anime list(#10)#16singhayushh wants to merge 1 commit intoProjectSakura:masterfrom singhayushh:issue-10
singhayushh wants to merge 1 commit intoProjectSakura:masterfrom
singhayushh:issue-10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: #10
Changes
After doing a lot of brainstorming, I finally found a simple hack to fix the empty ongoing list issue.
Just by adding a timeout of 3 seconds before rendering the home page, the cheerio and request functions are able to load the data completely before being passed to the frontend script.
Note
PR #14 had some previous commits added due to some error. This is a revised PR for the same changes with those commits removed. Merging #15 will merge this PR automatically.
Screenshot for reference
