Added additional check to only include heatstorages and not ates#340
Merged
samvanderzwan merged 7 commits intomainfrom Feb 12, 2026
Merged
Added additional check to only include heatstorages and not ates#340samvanderzwan merged 7 commits intomainfrom
samvanderzwan merged 7 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a stricter storage conversion path so only actual heat storages are treated as storages (and not misclassified ATES assets).
Changes:
- Introduces
get_esdl_type()on ESDL asset wrappers to expose an asset’s ESDL type as a string. - Refactors controller mapping to convert storages via a dedicated
convert_heat_storages_and_ates()helper and filters the “storage” set.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/omotes_simulator_core/entities/assets/esdl_asset_object.py | Adds get_esdl_type() used to distinguish true storages vs ATES. |
| src/omotes_simulator_core/adapter/transforms/controller_mapper.py | Refactors storage mapping into a helper and adds an extra filter step for storages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/omotes_simulator_core/adapter/transforms/controller_mapper.py
Outdated
Show resolved
Hide resolved
vanmeerkerk
requested changes
Feb 12, 2026
Contributor
vanmeerkerk
left a comment
vanmeerkerk
left a comment
There was a problem hiding this comment.
Kijk even of je een test kan toevoegen/aanpassen die echt checkt dat die ATES en HeatS|torage aparte lijsten zijn.
src/omotes_simulator_core/adapter/transforms/controller_mapper.py
Outdated
Show resolved
Hide resolved
src/omotes_simulator_core/adapter/transforms/controller_mapper.py
Outdated
Show resolved
Hide resolved
vanmeerkerk
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.