Fix crash in mod.cpp when JSON root object is different. #93
Merged
PoloNX merged 1 commit intoPoloNX:masterfrom Jul 9, 2025
Merged
Fix crash in mod.cpp when JSON root object is different. #93PoloNX merged 1 commit intoPoloNX:masterfrom
PoloNX merged 1 commit intoPoloNX:masterfrom
Conversation
Owner
|
Thanks. I need to work on this project again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimpleModDownloader crashed when installing the Super Smash Bros. mod here: https://gamebanana.com/mods/605724
Crash originated in
File::loadFile()frommod.cpp. The JSON returned fromhttps://gamebanana.com/apiv11/File/{fileID}did not have an_aMetadata._aArchiveFileTreeobject, instead the root object was just_aArchiveFileTree. This pull request adds logic checking for either object.