Description page for each Couple Type enhancement New feature or request frontend Codes that affects frontend#4
Open
evanwang9x wants to merge 11 commits intomainfrom
Open
Description page for each Couple Type enhancement New feature or request frontend Codes that affects frontend#4evanwang9x wants to merge 11 commits intomainfrom
evanwang9x wants to merge 11 commits intomainfrom
Conversation
huajie-zhong
added
enhancement
evanwang9x
changed the title
evanwang9x
changed the title
Contributor
|
I don't know why github UI didn't offer any easier way. But here is what happened: I was clearing outdated merged branch, but I realized that it automatically closes this PR as the branch was the branch to merge into, so I had to restore the branch to reopen and change base branch. |
…way from button towards the container
huajie-zhong
force-pushed
the
Evan/Couple-Type-Component
branch
from
341799b to
881efcb
Compare
Contributor
|
Hi Evan, I've just rebased your branch with the most up to date edits and color schema. I think the design team also has a high fidelity design ready for the Couple types, can you please look into Figma and update accordingly? Also a small bug, likely due to z-index, the navigation is being covered by the main page elements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done with issue#1
Contents of this component depends on what it has been called with. For now it defaults to homebody cause I have no clue how calling logic will work in the future
Dropdown component. I'll worry about improving its aesthetics when the design team gets around to it
Part of the http://localhost:3000/type page.
Screen.Recording.2025-06-30.at.11.42.44.AM.mov