[Custom Block Shape] Resize notches and reports upon registration#191
Open
Steve0Greatness wants to merge 1 commit intoPenguinMod:developfrom
Open
[Custom Block Shape] Resize notches and reports upon registration#191Steve0Greatness wants to merge 1 commit intoPenguinMod:developfrom
Steve0Greatness wants to merge 1 commit intoPenguinMod:developfrom
Conversation
Resizes custom notches and empty reporter slots upon registration of their respective parts, rather than waiting for a settings update. This does as little computation as is possible, such as relying on cached values, rather than doing such computations at registration. This does seem to miss registrations done prior to the addon running, however, those get handled by the applyChanges function already, so I'm not concerned about this, what this patch is concerned with in particular is actually the post-load registrations, which aren't handled by the applyChanges function.
|
You are a lifesaver thank you 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resizes custom notches and empty reporter slots upon registration of their respective parts, rather than waiting for a settings update. This does as little computation as is possible, such as relying on cached values, rather than doing such computations at registration. This does seem to miss registrations done prior to the addon running, however, those get handled by the applyChanges function already, so I'm not concerned about this, what this patch is concerned with in particular is actually the post-load registrations, which aren't handled by the applyChanges function until there is a change in settings, as there wouldn't have been a change in settings.