Open
Conversation
Setup CodeQL for SAST
Commit to add CodeQL workflow for Static App Security Testing.
Description
-----------
Commit to add CodeQL workflow for Static App Security Scanning.
Motivation and Context
----------------------
This commit allows us to run Github CodeQl as Github Actions and use CodeQL as a Static Application Security Testing tool to identify security vulnerabilities in code before it gets merged to `master` and deployments made.
Acceptance Criteria
-------------------
Screenshots (if appropriate)
----------------------------
Types of changes
----------------
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist
---------
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
- [x] My pull request addresses exactly one patch/feature.
- [x] I have created a branch for this patch/feature.
- [x] Each individual commit in the pull request is meaningful. (Please rebase, removing useless commits if not)
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [x] My code follows the code style of this project.
- [ ] My change requires change(s) to the environment.
<!--- Describe the environment changes if any-->
- [ ] My change requires change(s) to the database.
<!--- Describe the database changes if any-->
- [ ] Other information.
|
Kudos, SonarCloud Quality Gate passed!
|
michael-paystack
requested review from
Peter-John-paystack,
ali-paystack,
nathanstasin and
ravi-paystack
michael-paystack
requested changes
Aug 24, 2021
Member
michael-paystack
left a comment
michael-paystack
left a comment
There was a problem hiding this comment.
Can we change remove some of the comments that aren't particular to our use-case or at least modify them to suit the use in this repo.
| # The branches below must be a subset of the branches above | ||
| branches: [ master ] | ||
| schedule: | ||
| - cron: '35 16 * * 5' |
Member
There was a problem hiding this comment.
Hi @eyitemi-paystack,
Is there a need to run this on a schedule? I'm asking because all changes to master are setup to be analysed already?
Contributor
|
@eyitemi-paystack can you please address the comment on this PR so that we can proceed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup CodeQL for SAST
Commit to add CodeQL workflow for Static App Security Testing.
Description
Commit to add CodeQL workflow for Static App Security Scanning.
Motivation and Context
This commit allows us to run Github CodeQl as Github Actions and use CodeQL as a Static Application Security Testing tool to identify security vulnerabilities in code before it gets merged to
masterand deployments made.Acceptance Criteria
Screenshots (if appropriate)
Types of changes
Checklist
Fixes #0 (Enter the number for the issue this fixes. If you have not yet created an issue, please do so now or delete this line if you are only submitting a patch)
Changes made by this pull request