🩹[Patch]: Fix repo linting on merge to main #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves diagnostic logging and refines pull request event detection logic in the main PowerShell script. The changes ensure that only specific PR action types are recognized as "open or updated" PRs and add diagnostic output for GitHub event context.
Changes:
- Added logging of GitHub event input environment variables (event name, action, and PR merged status)
- Changed
isOpenOrUpdatedPRcondition from excluding 'closed' to explicitly listing valid actions ('opened', 'reopened', 'synchronize') - Added explicit 'closed' action check to
isMergedPRcondition for consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MariusStorhaug
changed the title
MariusStorhaug
changed the title
MariusStorhaug
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release updates the logic for determining pull request states in the
scripts/main.ps1script, making the conditions for open, updated, abandoned, and merged pull requests more precise and adding improved logging for GitHub event inputs.Improvements to PR state detection:
$isOpenOrUpdatedPRcondition to trigger only for'opened','reopened', or'synchronize'actions, making it more accurate than the previous logic.$isMergedPRcondition to require both the'closed'action and that the PR is marked as merged, preventing false positives.Logging enhancements: