[18.0][IMP] pos_order_remove_line: Add config show button remove order line #7
Conversation
…s when deleting an orderline from remove-line-button.
- Function logic is modified in order to use the numpad backspace trigger. - Stops event propagation and prevents default actions.
P-H-Phuc
changed the title
| /> | ||
| </div> | ||
| <div> | ||
| <field name="pos_line_remove_warning" /> |
There was a problem hiding this comment.
show it only when pos_line_remove_btn is ticked
There was a problem hiding this comment.
Need to click 2 times to remove item, it focus to paren element, I will check it
There was a problem hiding this comment.
Show the remove button only when the order line is selected!
There was a problem hiding this comment.
No, it's not a good idea. Always show the btn as it's.
Try to solve the issue. Spend more time, let me know if you cannot find the solution then.
There was a problem hiding this comment.
Screencast.from.2025-11-25.11-33-41.webm
There was a problem hiding this comment.
Resolve! please help me to review this
P-H-Phuc
force-pushed
the
18.0-imp-pos_order_remove_line
branch
2 times, most recently
from
b977fc6 to
5bda1ce
Compare
|
Resolved |
| /> | ||
| </div> | ||
| <div> | ||
| <field name="pos_line_remove_warning" /> |
There was a problem hiding this comment.
No, it's not a good idea. Always show the btn as it's.
Try to solve the issue. Spend more time, let me know if you cannot find the solution then.
P-H-Phuc
force-pushed
the
18.0-imp-pos_order_remove_line
branch
from
5bda1ce to
7722cad
Compare
| }, | ||
| _executeRemove() { | ||
| this.numberBuffer.sendKey("Backspace"); | ||
| this.numberBuffer.sendKey("Backspace"); |
There was a problem hiding this comment.
It's a little funny when there are 2 lines look-alike.
Please try this one instead:
const order = this.pos.get_order();
const selectedLine = order.get_selected_orderline();
order.removeOrderline(selectedLine);
There was a problem hiding this comment.
If change it like that, it will cause a bug. For example, if line 3 is currently selected and you delete line 1, line 3 ends up being deleted instead.
Screencast.from.2026-01-22.17-36-37.webm
There was a problem hiding this comment.
Ok, if so, please comment to explain why you have 2 lines of this.numberBuffer.sendKey("Backspace");.
This will help the maintainer and later migration.
P-H-Phuc
force-pushed
the
18.0-imp-pos_order_remove_line
branch
from
7722cad to
0262952
Compare
P-H-Phuc
force-pushed
the
18.0-imp-pos_order_remove_line
branch
from
0262952 to
17846c6
Compare
ISSUE