-
Notifications
You must be signed in to change notification settings - Fork 4
[iOS]Rework Optable API configuration and request forming #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ableSDK interface with async/await support
eugenedorfman-optable
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - reviewed as part of #51 (when it was submitted from a postindustria-tech fork, now resubmitted from an Optable branch)
| if config.skipAdvertisingIdDetection == false, | ||
| ATT.advertisingIdentifierAvailable, | ||
| ATT.advertisingIdentifier != UUID(uuid: uuid_t(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0)), | ||
| ids[.appleIDFA] != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the intention to only override existing appleIDFA with device AdvertiserID or to always set it when it's not set?
This PR addresses the following issues:
Add Prebid SDK and passing optable IDs into the demo app #43
Prebid test case was merged to into this PR, the old PR can be closed.
Rework Optable Real-time APIs configuration and request forming #49
SDK was updated according to real time api integrations guide
Extend Optable Targeting API request forming with additional parameters #50
SDK Targeting API was updated to accept arbitrary IDs as defined in real time api integrations guide. Privacy parameters is controlled via
OptableConfig.Breaking changes:
OptableSDK.init(host:, app:, insecure:, useragent:)was replaced withOptableSDK.init(config:)tenantandoriginSlugparameters to initialise, instead ofhostandappOptableConfigwas introduced to contain all configuration parameters for the SDKOptableConfigsupports dynamic changes of all parameters, such ashost,path,apiKey,custopUserAgentand others.Other changes:
IABConsentfor automatically retrieving user consent according to the IAB Transparency & Consent FrameworkAppTrackingTransparencyto handle App Tracking IdentifiersOptableIdentifierType,OptableIdentifiers, andOptableIdentifierEncoderto support optable identifiers and normalisationasync/awaitSDK API for modern swift