Fix/update for post-quantum cryptography in TLS#212
Open
vcrhonek wants to merge 2 commits intoOpenwsman:mainfrom
Open
Fix/update for post-quantum cryptography in TLS#212vcrhonek wants to merge 2 commits intoOpenwsman:mainfrom
vcrhonek wants to merge 2 commits intoOpenwsman:mainfrom
Conversation
Remove deprecated 'EC_KEY_new_by_curve_name' and add configuration option for fall back certificate/key pair. Signed-off-by: Vitezslav Crhonek <vcrhonek@redhat.com>
- Use _shttpd_report_ssl_error instead of _shttpd_elog - Fix bug where 'pem' parameter was used instead of actual file paths Signed-off-by: Vitezslav Crhonek <vcrhonek@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
OpenSSL 3.5 offers post quantum cryptography (PQC) support:
See https://github.com/openssl/openssl/releases for more info.
Additional info can be found in these drafts:
https://datatracker.ietf.org/doc/html/draft-kwiatkowski-tls-ecdhe-mlkem-03
https://datatracker.ietf.org/doc/html/draft-ietf-lamps-dilithium-certificates-07
a)
openwsman DOESN'T use post-quantum key exchange by default if the peer supports it:
This is because 'EC_KEY_new_by_curve_name()' usage. Patch removes this function, which is deprecated since OpenSSL 3.0 anyway. See https://docs.openssl.org/3.0/man3/EC_KEY_new/
TLS 1.3 and the X25519MLKEM768 key exchange is used by default if the peer supports it then:
b)
This change makes 'owsmangencert.sh' generate ML-DSA certificate:
If one wants to use a TLS certificate using ML-DSA , then connection works as expected (assuming 'EC_KEY_new_by_curve_name()' was already removed):
But openwsman DOESN'T support an ML-DSA certificate and classic certificate chain (fall back for clients not having access to PQC) at the same time. There's no configuration or option to load more than one certificate in the server. This could be useful and the rest of the patch implements this functionality.