Conversation
53f760f to
faddc63
Compare
caseylocker
left a comment
There was a problem hiding this comment.
@matiasperrone-exo
Wrong namespace in security schema:
// Current (line 3)
namespace App\Swagger\Security;
// Should be
namespace App\Swagger\schemas;
Wrong x: parameter key (6 occurrences): Lines 297, 558, 620, 689, 738, 799 all have:
// Current
x: ["authz_groups" => [IGroup::SuperAdmins, IGroup::Administrators, IGroup::SummitAdministrators, IGroup::SummitRegistrationAdmins]],
// Should be
x: ["required-groups" => [IGroup::SuperAdmins, IGroup::Administrators, IGroup::SummitAdministrators, IGroup::SummitRegistrationAdmins]],
cc9ed24 to
9140b86
Compare
|
Thanks @caseylocker for the comments. Now is ready to review again |
caseylocker
left a comment
There was a problem hiding this comment.
@matiasperrone-exo regenerate the docs locally and you'll see the issue.
In SummitRegistrationSchemas.php line 98:
Cannot declare class App\Swagger\schemas\SummitTicketTypeAddRequestSchema, because the name is already in use
bba4f04 to
7fdfe2d
Compare
c6ecdd0 to
728ae67
Compare
7fdfe2d to
8d284a9
Compare
8d284a9 to
070cfdb
Compare
There was a problem hiding this comment.
@matiasperrone-exo
Generation is failing from a duplicate operationID. Please see test output.
operationId must be unique. Duplicate value found: "getAllTicketTypesBySummit"
|
Thanks @caseylocker for the comments. Now is ready to review again |
…OAuth2 security and request schemas
…TTP codes Signed-off-by: Matias Perrone <github@matiasperrone.com>
Signed-off-by: Matias Perrone <github@matiasperrone.com>
fea24cc to
92446bc
Compare
Signed-off-by: Matias Perrone <github@matiasperrone.com>
70637fb to
5c41fe9
Compare
Task:
Ref: https://app.clickup.com/t/86b6wkhah