Conversation
a99a175 to
c38cdc7
Compare
caseylocker
left a comment
There was a problem hiding this comment.
@matiasperrone-exo
Wrong namespace in security schema:
// Current (line 3)
namespace App\Swagger\Security;
// Should be
namespace App\Swagger\schemas;
Wrong x: parameter key (8 occurrences): Lines 85, 155, 222, 295, 361, 466, 548 all have:
// Current
x: ["authz_groups" => [IGroup::SuperAdmins, IGroup::Administrators, IGroup::TrackChairs, IGroup::TrackChairsAdmins]],
// Should be
x: ["required-groups" => [IGroup::SuperAdmins, IGroup::Administrators, IGroup::TrackChairs, IGroup::TrackChairsAdmins]],
e23bdff to
b8a15ee
Compare
caseylocker
left a comment
There was a problem hiding this comment.
'removePresentationFromMyIndividualList' in app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSelectedPresentationListApiController.php is a Delete operation but the response is 201 with 'Created' description. Technically correct, based on the underlying code, but the description can be confusing. Change the description to "Removed from List" so...
new OA\Response(
response: 201,
description: "Created", // ← Incorrect for DELETE operation
becomes
new OA\Response(
response: 201,
description: "Removed from list",
711976c to
c51add6
Compare
c6ecdd0 to
728ae67
Compare
c51add6 to
bda7450
Compare
…sentationListApiController`
- moves anyOf to not be in the required, and properties there should be in the main properties param.
Signed-off-by: Matias Perrone <github@matiasperrone.com>
bda7450 to
ba62c96
Compare
Task:
Ref: https://app.clickup.com/t/86b6wkh94