Conversation
smarcet
force-pushed
the
main
branch
2 times, most recently
from
4f4b976 to
9ed27c0
Compare
matiasperrone-exo
changed the title
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---marketplace--appliancesapicontroller
branch
from
e351a77 to
68a9fce
Compare
matiasperrone-exo
requested review from
smarcet
and removed request for
smarcet
smarcet
force-pushed
the
main
branch
2 times, most recently
from
e3e142a to
161d4d3
Compare
smarcet
reviewed
Oct 1, 2025
app/Http/Controllers/Apis/Marketplace/AppliancesApiController.php
Outdated
Show resolved
Hide resolved
smarcet
requested changes
Oct 1, 2025
Collaborator
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@matiasperrone-exo please review comments
Contributor
Author
|
@smarcet please review, all the requested changes were incorporated. |
smarcet
force-pushed
the
main
branch
7 times, most recently
from
c94fc68 to
9a8387b
Compare
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---marketplace--appliancesapicontroller
branch
from
e468edb to
872bc36
Compare
matiasperrone-exo
added
the
documentation
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---marketplace--appliancesapicontroller
branch
from
0ea1505 to
0918db2
Compare
matiasperrone-exo
changed the title
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---marketplace--appliancesapicontroller
branch
2 times, most recently
from
5d7c624 to
98fdeda
Compare
smarcet
requested changes
Nov 14, 2025
Collaborator
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@matiasperrone this PR has the same issues than @matiasperrone this PR has the same issues than #359
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---marketplace--appliancesapicontroller
branch
from
86778e8 to
47b070e
Compare
Collaborator
|
@matiasperrone please lets rebase against main and fix the conflicts many thanks |
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---marketplace--appliancesapicontroller
branch
2 times, most recently
from
8f5aafb to
7bd4a20
Compare
caseylocker
approved these changes
Dec 10, 2025
Contributor
Author
|
needs rebase. fixing now |
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---marketplace--appliancesapicontroller
branch
from
7bd4a20 to
4918d0e
Compare
Contributor
Author
|
@caseylocker was rebased now is working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task:
Ref: https://app.clickup.com/t/86b6wkfz0