Conversation
smarcet
force-pushed
the
main
branch
4 times, most recently
from
4f4b976 to
9ed27c0
Compare
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller-countriesapicontroller
branch
from
acabde8 to
6cb5226
Compare
matiasperrone-exo
changed the title
matiasperrone-exo
changed the title
smarcet
force-pushed
the
main
branch
2 times, most recently
from
e3e142a to
161d4d3
Compare
smarcet
reviewed
Oct 1, 2025
smarcet
requested changes
Oct 1, 2025
Collaborator
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@matiasperrone-exo please review
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller-countriesapicontroller
branch
from
907d910 to
07e7ea0
Compare
smarcet
force-pushed
the
main
branch
6 times, most recently
from
76ff504 to
65b16a8
Compare
smarcet
reviewed
Oct 3, 2025
app/Swagger/schemas.php
Outdated
| class RSVPAdminAddRequestSchema {} No newline at end of file | ||
| class RSVPAdminAddRequestSchema {} | ||
|
|
||
| #[OA\Schema( |
Collaborator
There was a problem hiding this comment.
@matiasperrone-exo we need to start to break down this schema file on several files ( like one file responsability
- marketplace
- rsvp
- general
and so
smarcet
requested changes
Oct 3, 2025
Collaborator
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@matiasperrone-exo please review comments
Contributor
Author
|
@smarcet As discussed, the generic schemas will be living in the main schemas.php file. |
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller-countriesapicontroller
branch
from
07e7ea0 to
c6b0f98
Compare
matiasperrone-exo
added
the
documentation
matiasperrone-exo
changed the title
CountriesApiController
smarcet
force-pushed
the
feature/add-openapi-documentation-to-controller-countriesapicontroller
branch
from
c6b0f98 to
4cbac93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task:
Ref: https://app.clickup.com/t/86b6rgvu3